snapshot and batching removal, recovery transactions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes snapshotting and batching from the storage. These lead to rather high memory usage in some cases and they can be later reimplemented as an additional layer if necessary. Tuning LevelDB configuration seems to give enough performance. * Adds MarkRecovered method on the storage interface. This is used to signal that recovery has finished and that the processor/view can expect a lower message rate. Default storage uses this to disable LevelDB compaction via a transaction during recovery and re-enabling it afterwards. * Removes StoragePath option. StorageBuilder now takes a complete storage path. Two helpers functions were added for generating default storage paths for views and processors.
frairon
approved these changes
Aug 24, 2017
|
Thanks, merging! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes snapshotting and batching from the storage. These lead
to rather high memory usage in some cases and they can be later
reimplemented as an additional layer if necessary. Tuning
LevelDB configuration seems to give enough performance.
Adds MarkRecovered method on the storage interface. This is used
to signal that recovery has finished and that the processor/view
can expect a lower message rate. Default storage uses this to
disable LevelDB compaction via a transaction during recovery and
re-enabling it afterwards.
Removes StoragePath option. StorageBuilder now takes a complete
storage path. Two helpers functions were added for generating
default storage paths for views and processors.
closes Remove snapshot from storage #30